Skip to content

Merge changes from vNext to main#526

Merged
wraschke merged 8 commits into
WASdev:mainfrom
wraschke:vNext_to_main
Jul 26, 2023
Merged

Merge changes from vNext to main#526
wraschke merged 8 commits into
WASdev:mainfrom
wraschke:vNext_to_main

Conversation

@wraschke

Copy link
Copy Markdown
Member

No description provided.

@wraschke wraschke changed the title V next to main Merge changes from vNext to main Jul 24, 2023
@leochr

leochr commented Jul 25, 2023

Copy link
Copy Markdown
Member

@wraschke Ubuntu changes look good. Thank you. The changes from following PRs to latest should also be applied to equivalent files in 23.0.0.7:

@mbroz2

mbroz2 commented Jul 25, 2023

Copy link
Copy Markdown
Contributor

LGTM (but not marking it approved based on Leo's comments to ensure they get added).

@leochr

leochr commented Jul 25, 2023

Copy link
Copy Markdown
Member

@wraschke I am not sure why GitHub is not showing your latest commit in this PR. So I looked at the last commit to your branch : 2aa3adf

There is a whitespace in some of the kernel Dockerfiles (after && ln -s /opt/ibm/wlp /liberty \), which I don't think will cause any issues, but not entirely sure. Apart from that, it looks good.

Perhaps, close this PR and open a new PR. Hopefully, that'll include the new commit. Thank you

@wraschke wraschke merged commit 0d46a62 into WASdev:main Jul 26, 2023
@wraschke wraschke deleted the vNext_to_main branch October 27, 2023 16:31
@wraschke wraschke restored the vNext_to_main branch October 27, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants